Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] if __name__ == '__main__', fix #3775 (#3788) #3789

Merged
merged 1 commit into from
May 22, 2019
Merged

[3.5] if __name__ == '__main__', fix #3775 (#3788) #3789

merged 1 commit into from
May 22, 2019

Conversation

asvetlov
Copy link
Member

(cherry picked from commit 506c244)

Co-authored-by: Samuel Colvin [email protected]

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@samuelcolvin @asvetlov
[3.5] if __name__ == '__main__', fix #3775 (#3788)
b230dba 
(cherry picked from commit 506c244)

Co-authored-by: Samuel Colvin <[email protected]>
@asvetlov asvetlov requested a review from webknjaz as a code owner May 21, 2019 16:37
@codecov-io
Copy link

codecov-io commented May 21, 2019 •
edited
Loading

Codecov Report

Merging #3789 into 3.5 will decrease coverage by 3.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.5    #3789      +/-   ##
==========================================
- Coverage   97.94%   94.88%   -3.07%     
==========================================
  Files          44       44              
  Lines        8576     8575       -1     
  Branches     1380     1379       -1     
==========================================
- Hits         8400     8136     -264     
- Misses         71      334     +263     
  Partials      105      105
Impacted Files Coverage Δ
aiohttp/worker.py 6.55% <0%> (-90.99%) ⬇️
aiohttp/resolver.py 46.55% <0%> (-53.45%) ⬇️
aiohttp/web_fileresponse.py 66.66% <0%> (-29.89%) ⬇️
aiohttp/tcp_helpers.py 63.33% <0%> (-26.67%) ⬇️
aiohttp/locks.py 92.85% <0%> (-7.15%) ⬇️
aiohttp/web_runner.py 91.7% <0%> (-6.22%) ⬇️
aiohttp/__init__.py 94.73% <0%> (-5.27%) ⬇️
aiohttp/http_parser.py 93.11% <0%> (-4.82%) ⬇️
aiohttp/http_writer.py 95.28% <0%> (-2.84%) ⬇️
aiohttp/frozenlist.py 97.87% <0%> (-2.13%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2354926...b230dba. Read the comment docs.

@asvetlov asvetlov closed this May 22, 2019
@asvetlov asvetlov reopened this May 22, 2019
@asvetlov
Copy link
Member Author

Travis is weirdly broken, I'm merging the PR with red checks.

@asvetlov asvetlov merged commit 722fe79 into 3.5 May 22, 2019
@asvetlov asvetlov deleted the backport-506c244-3.5 branch May 22, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asvetlov @codecov-io @samuelcolvin